WoD Scripts

[Wolfsong]

Are WoD scripts public? Like is there a github I can go and download them all at?

[Agata]

I haven't set that up yet, but I will.

[Wolfsong]

Awesome, I can't wait =D

[Kranisar Loranah]

I do remember seeing a pol wod scripts at the pol site.Not sure how old these are.But if you are bored. https://forums.polserver.com/viewtopic.php?f=43&t=2730

[Agata]

It's VERY old and the guy who did that porting had no idea of what he was doing. I originally intended to use it as base for porting the scripts to POL 099, but in the end I dropped it entirely in order to keep my sanity. I repeat, the guy had no idea of what he was doing, he was evidently NOT a programmer, not even an average scripter. If you are at least an average scripter, the level of cringe inducing things he did will make you want to hit him on the face with a baseball bat.

[Kranisar Loranah]

He sounds like a programmer I knew of. You would change one detail in a subroutine and it would break 50 more because nothing was separate. Needless to say it was one big mess!

[Agata]

Not to that degree, but I will give you one example of things he did...
POL 095 is not "realm aware", so it only uses the Felucca map. The function to move an item to a specific location is:

Code: Select all

MoveItemToLocation( item, x, y, z, flags )

On POL 098, there is realm awareness, you can access Felucca, Trammel, Ilshenar, Malas, Tokuno, Ter Mur... so the function to move items was changed, as it now has the "realm" parameter. The POL 098 documentation shows the definition of the function like this:

Code: Select all

MoveObjectToLocation( object, x, y, z, realm := _DEFAULT_REALM, flags := MOVEOBJECT_NORMAL )

So, what he did on the WoD scripts was replace the MoveItemToLocation() calls with MoveObjectToLocation(), but in the realm parameter he put the complete "realm := _DEFAULT_REALM" string, like this:

Code: Select all

MoveObjectToLocation( item, destx, desty, destz, realm := _DEFAULT_REALM, flags := MOVEOBJECT_NORMAL )

Had he known what he was doing, he would have AT LEAST done something like this instead:

Code: Select all

MoveObjectToLocation( item, destx, desty, destz, _DEFAULT_REALM, MOVEOBJECT_NORMAL )

Or even create a proper destrealm variable with the desired realm.

[Laephis]

Hah, tell us how you really feel, Agata.

[Agata]

https://github.com/agata-wod/wod

[Wolfsong]

And so it begins